Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1145952034
Hey @showuon , just looking to see if you have any input on the last commit
I made to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1134854139
@showuon I've gone ahead and added more tests as suggested. Happy to receive
feedback on them! In addition, I opened the following jira as we agreed to to
track integration tests:
[KAFKA
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131755255
Thanks for the quick responses. To your first answer, I'm happy to do that
and will take a look at the TopciCommandTest for guidance.
To your second answer. Integration tests for t
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1129000522
@showuon happy to try and help. For my sake since this is the first code
contribution I've made, could you help me out by answering some questions?
1. When you say add some test for wro