[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1303027263 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3624,14 +3624,18 @@ class ReplicaManagerTest { val remoteLogManagerConfig = new

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1303026451 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -285,19 +288,15 @@ public RemoteStorageManager storageManager() { return

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1303025695 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -378,7 +372,7 @@ public void stopPartitions(Set topicPartitions,

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1296606986 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3600,7 +3600,10 @@ class ReplicaManagerTest { "clusterId", time, _

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1296606546 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -802,41 +817,25 @@ private void verifyInCache(TopicIdPartition... topicIdPartitions) {

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1292378925 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -280,13 +285,18 @@ public RemoteStorageManager storageManager() { return

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1292378582 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -347,15 +353,16 @@ public void onLeadershipChange(Set partitionsBecomeLeader, public

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1285865061 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -347,15 +353,16 @@ public void onLeadershipChange(Set partitionsBecomeLeader, public

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

Owen-CH-Leung commented on code in PR #14136: URL: https://github.com/apache/kafka/pull/14136#discussion_r1285857919 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -144,8 +145,9 @@ public class RemoteLogManager implements Closeable { private final