[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-12 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1097543104 Hi @guozhangwang Thank you very much. I would appreciate it if you had time to help review KIP-828. I have listed all configurations missing validators in this KIP. Thanks --

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-12 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1097458348 Hi @mimaison Please help to review when you are free. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-10 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1094440416 Hi @showuon @mimaison could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-05 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1089641523 Hi @showuon @mimaison could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-04 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1087584508 Hi @showuon @dajac and @mimaison could you help to review the PR? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-02 Thread GitBox
RivenSun2 commented on pull request #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1086758489 Because a validator is added to `ProducerConfig.COMPRESSION_TYPE_CONFIG` and `KafkaConfig.CompressionTypeProp`, the corresponding testCase is improved to verify whether the

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-01 Thread GitBox
RivenSun2 commented on pull request #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1086549836 Hi @showuon @dajac please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to