[GitHub] [kafka] Schm1tz1 commented on pull request #12992: KAFKA-14376-KIP887: Add ConfigProvider to make use of environment variables

2023-04-05 Thread via GitHub
Schm1tz1 commented on PR #12992: URL: https://github.com/apache/kafka/pull/12992#issuecomment-1497915645 > Please fix the missing new line issues, otherwise looks good. Thanks! Newlines are fixed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Schm1tz1 commented on pull request #12992: KAFKA-14376-KIP887: Add ConfigProvider to make use of environment variables

2023-04-05 Thread via GitHub
Schm1tz1 commented on PR #12992: URL: https://github.com/apache/kafka/pull/12992#issuecomment-1497209688 Done - just passed local build, test and checkstyle. Will push the changes now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] Schm1tz1 commented on pull request #12992: KAFKA-14376-KIP887: Add ConfigProvider to make use of environment variables

2023-03-20 Thread via GitHub
Schm1tz1 commented on PR #12992: URL: https://github.com/apache/kafka/pull/12992#issuecomment-1475939063 > Can you reply to the DISCUSS/VOTE threads explaining the changes you made since the KIP was accepted? Sure, just sent an update to the KIP thread: