[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-635041609 Great work, @feyman2016 @mjsax ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-633733992 Only known flaky EOS tests are failing: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-19 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-630918452 @feyman2016 Thanks for the context. I don't worry too much for comment vanish if you change the commit history, as they would not be gone but just show as `outdated` on github.

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-15 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-629591570 @feyman2016 no worry! It's just for first time :) This is an automated message from the Apache Git Service. To