[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424830762 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ConstrainedPrioritySet.java ## @@ -16,77 +16,58 @@ */

[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424758127 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java ## @@ -236,16 +233,17 @@

[GitHub] [kafka] ableegoldman commented on a change in pull request #8588: KAFKA-6145: KIP-441: Improve assignment balance

2020-05-13 Thread GitBox
ableegoldman commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r424729806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ConstrainedPrioritySet.java ## @@ -16,77 +16,58 @@ */