[GitHub] [kafka] acsaki commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-10 Thread GitBox
acsaki commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1152416005 Thank you @showuon, @tombentley and @SamBarker for the review, guidance and help! I'm really happy to see my first contribution merged, thank you! -- This is an automated message from

[GitHub] [kafka] acsaki commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-09 Thread GitBox
acsaki commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1150937597 Thanks @showuon , I really like the idea that we should set `sessionExpirationTimeNanos` regardless whether max reauth is set or not, otherwise clients probably won't get disconnected

[GitHub] [kafka] acsaki commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-03 Thread GitBox
acsaki commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1145812750 > Nice tests! Thank you. Left some comments. Also, I found there are many tests failed with the error: > > ``` > org.opentest4j.AssertionFailedError: Topic [__consumer_offsets]

[GitHub] [kafka] acsaki commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-05-31 Thread GitBox
acsaki commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1142294491 > @acsaki , we haven't get your response for some days, do you need help on it? We can co-author with you to address the comments and fix the tests. Please let me know. Thank you.