albert02lowis commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-674421636
Thanks for the reviews too @bbejeck and @abbccdda ! Really excited as this
is my first contribution 🙏🏻
Thi
albert02lowis commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667850415
Hi @abbccdda sure thing, I have added 2 more commits to this PR and the unit
+ integration tests also looks good in my local
---
albert02lowis commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667462930
Hi, there's another unit test that need to be moved out
(`StreamStreamJoinIntegrationTest.shouldNotAccessJoinStoresWhenGivingName`) but
I thought of doing that in another PR
