[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-10 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r468175154 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -70,37 +80,38 @@ class ConnectionQuotasTest {

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r454010650 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java ## @@ -572,16 +572,18 @@ public synchronized void

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453965142 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } //

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453962326 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } //

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-10 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453131010 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } //

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-10 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r453130277 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -329,15 +613,46 @@ class ConnectionQuotasTest { } // this

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-09 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r452507990 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1308,18 +1410,27 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-07-09 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r452502811 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1289,15 +1311,95 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r439786379 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1287,15 +1309,97 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-13 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r439786166 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -161,6 +162,9 @@ private KafkaMbean

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-11 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r439143850 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1256,11 +1272,17 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)