artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1192047420
Hi @etolbakov, making this method private sounds reasonable to me. Thank
you for suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the me
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189805608
Looked at the failed tests, seem unrelated and pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189712085
> Are the test failures related to the PR?
Yes, just pushed the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1185997352
@junrao, @ijuma thank you for reviews, I've updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1170664838
Haven't checked the streams benchmark yet. But it is a regression that is
visible in the lock profile, so from that perspective seems to be a net
positive.
--
This is an automat
