[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1107962390 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -389,22 +389,27 @@ public void logUnused() { private T getConfiguredInstance(Obj

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1107961671 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -599,6 +624,31 @@ public TestConfig(Map props) { } } +private

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() { testInvalidInput

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() { testInvalidInput

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() { testInvalidInput

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() { testInvalidInput

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092652543 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass, Class t, Map T getC

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092652543 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -414,34 +414,51 @@ private T getConfiguredInstance(Object klass, Class t, Map T getC

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092516181 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -168,6 +169,7 @@ public class KafkaConsumerTest { private final int default

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092513735 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -54,6 +58,12 @@ public void testConfiguredInstances() { testInvalidInput

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1092017609 ## clients/src/test/java/org/apache/kafka/test/MockConsumerInterceptor.java: ## @@ -55,6 +58,11 @@ public void configure(Map configs) { Object clientIdValue = c

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M