[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-23 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-697508626 rebase to include the fixes of flaky. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-23 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-697164367 ``` Build / JDK 15 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota ``` it is traced by #9301 ```

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-696522007 rebase to run JMH again. This patch is still a benefit to validation :) This is an automated message from the

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-21 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-696522007 rebase to run JMH again. This patch is still a benefit to validation :) This is an automated message from the

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-26 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-680715966 > Do you have any data on the improvement this achieves? @ijuma the JMH result is attached. please take a look.

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-23 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678753750 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-08-22 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678722242 > Do you have any data on the improvement this achieves? I profiled (1 minute) one of servers (10 cores * 128 GB) without /without this patch. The tuple allocations is