[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-18 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-711165284 ``` org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync ``` unrelated error

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-09 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-705979334 @hachikuji @dajac Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-08 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-705979334 @hachikuji @dajac Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-07 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-705311185 ``` Build / JDK 8 / kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs ``` pass on my local. rebase to trigger QA

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-04 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-703413622 @dajac I have addressed your comment. please take a look. The features of auto-generated protocol is good to cleanup code :)

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-04 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-703261060 ``` Build / JDK 15 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` unrelated error. rebase to

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-01 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-702265223 the archetype error is fixed by https://github.com/apache/kafka/commit/12d98a3d7ad9b023c600bdbb5e3ffb42b07406b1

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-28 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-699902060 rebase to fix conflicts This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-699025146 @dajac @hachikuji Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-23 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-697504023 rebase to fix conflicting This is an automated message from the Apache Git Service. To respond to the message,