chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-780309024
@g1geordie Thanks for your updating. I will merge it tomorrow :)
This is an automated message from the Apache
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-768769711
For another, ```testWriteControlBatchNotAllowedMagicV0``` and
```testWriteControlBatchNotAllowedMagicV1``` are almost same. Could we merge
them into single test case?
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-766549241
@g1geordie Could you merge trunk to include the recent bug fixes?
This is an automated message from the Apache
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-766549241
@g1geordie Could you merge trunk to include the recent bug fixes?
This is an automated message from the Apache
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-762364993
@g1geordie Personally, current approach is a bit hard to read to me. It
seems to me the "parameterized" arguments should be simple and readable. We
should be able to understand
