[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1023036927 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -30,17 +30,16 @@ import org.apache.kafka.connect.util.Callback

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1023035464 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java: ## @@ -134,7 +134,7 @@ public void configure(final WorkerConfig config) {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1023035089 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,33 +112,58 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1023034803 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -385,114 +377,64 @@ public void testSetFailure() throws Excepti

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721786 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721355 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015640636 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639560 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639016 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java: ## @@ -214,7 +214,7 @@ public void configure(final WorkerConfig config) {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r937576532 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -103,36 +103,57 @@ public class KafkaOffsetBackingStoreTest {