[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-27 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1276543815 ## storage/api/src/test/java/org/apache/kafka/server/log/remote/storage/NoOpRemoteLogMetadataManager.java: ## @@ -74,6 +74,11 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-27 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1276037068 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -168,4 +169,64 @@ private void

[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-27 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1276036551 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -327,6 +327,17 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-26 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1275018018 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -168,4 +169,64 @@ private void

[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-26 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1274701153 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -327,6 +327,17 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-25 Thread via GitHub
clolov commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1273206652 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java: ## @@ -201,4 +201,13 @@ void onPartitionLeadershipChanges(Set