[GitHub] [kafka] clolov commented on pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

clolov commented on PR #13621: URL: https://github.com/apache/kafka/pull/13621#issuecomment-1521580408 Great! Thank you @cadonna, I will aim to address the comments either today or tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] clolov commented on pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

clolov commented on PR #13621: URL: https://github.com/apache/kafka/pull/13621#issuecomment-1517474714 I believe the related test failures are due to the same problem as https://github.com/apache/kafka/pull/13529#discussion_r1168432918. Once that PR is merged and this one is rebased those

[GitHub] [kafka] clolov commented on pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

clolov commented on PR #13621: URL: https://github.com/apache/kafka/pull/13621#issuecomment-1516499410 Heya @cadonna! I hope this attempt is what you had in mind? Unless I am wrong the removals detailed in the pull request are sensible as Mockito should be returning empty collections for