[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971319874 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971280735 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971280346 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971279173 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971095900 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +173,58 @@ StandardAuthorizerData copyWithNewConfig(int

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971094152 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971092861 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -109,14 +110,9 @@ public class StandardAuthorizerData { private

[GitHub] [kafka] cmccabe commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

cmccabe commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971091182 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }