[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1124830672 ## metadata/src/test/java/org/apache/kafka/image/ScramImageTest.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120967385 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in ${deltaName}",

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in ${deltaName}",

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120961672 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -99,6 +99,7 @@ class ControllerApis(val requestChannel: RequestChannel, case ApiKeys.INCREMENTA