[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156401794 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -395,9 +395,7 @@ private void formatNodeAndLog(MetaProperties properties, String metadataLogDir,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156401424 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -235,9 +379,21 @@ object StorageTool extends Logging { metaProperties: MetaProperties,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156400641 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java: ## @@ -40,11 +48,13 @@ public enum ScramMechanism { MECHANISMS_M

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint, KafkaCo

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint, KafkaCo

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149876669 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -128,6 +152,108 @@ object StorageTool extends Logging { .getOrElse(defaultValue) } + def getUse

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint, KafkaCo

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1146574776 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -221,4 +224,78 @@ Found problem: assertThrows(classOf[IllegalArgumentException], () => pars

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1146573531 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -128,6 +152,108 @@ object StorageTool extends Logging { .getOrElse(defaultValue) } + def getUse