[GitHub] [kafka] cmccabe commented on pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

2023-04-17 Thread via GitHub
cmccabe commented on PR #13513: URL: https://github.com/apache/kafka/pull/13513#issuecomment-1511734452 Here's a Jenkins failure I have not seen before. ``` 671 [2023-04-11T13:07:59.254Z] FAILURE: Build failed with an exception. 672 [2023-04-11T13:07:59.254Z] 673 [2023-04-11T1

[GitHub] [kafka] cmccabe commented on pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

2023-04-10 Thread via GitHub
cmccabe commented on PR #13513: URL: https://github.com/apache/kafka/pull/13513#issuecomment-1502329503 > Should I move ScramCredentialData.java from metadata/src/main/java/org/apache/kafka/image to metadata/src/main/java/org/apache/kafka/metadata ? yes, please. -- This is an auto

[GitHub] [kafka] cmccabe commented on pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

2023-04-06 Thread via GitHub
cmccabe commented on PR #13513: URL: https://github.com/apache/kafka/pull/13513#issuecomment-1499594184 Thanks for this, @pprovenzano . Seems like a relatively straightforward change. However, you need to give a reason why we should do this. I think the reason here is for compatibility with