[GitHub] [kafka] cmccabe commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

2023-04-12 Thread via GitHub
cmccabe commented on PR #13521: URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505765473 Sure. The test is valid since it's testing the `PartitionChangeBuilder` and we do want it to have the behavior you're describing. Thanks for the explanation. LGTM -- This is an

[GitHub] [kafka] cmccabe commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

2023-04-12 Thread via GitHub
cmccabe commented on PR #13521: URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505631320 Thanks for tackling this! Question about the first test: > First, it adds a test that makes sure we handle what happens when a reassignment completes and none of the new