[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-26 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446192909 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1018,6 +1097,15 @@ class LogManager(logDirs: Seq[File], byDir } + private def

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-26 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446192217 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -433,29 +425,34 @@ class ReplicaManager(val config: KafkaConfig, case

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-26 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r446190937 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -459,7 +459,12 @@ class Partition(val topicPartition: TopicPartition, } } -

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-09 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436704800 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -273,7 +272,7 @@ private[log] class LogCleanerManager(val logDirs: Seq[File], *

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-08 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436532135 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -324,8 +324,17 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-08 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436523916 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -878,8 +936,7 @@ class LogManager(logDirs: Seq[File], // Now that replica in

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-08 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436519796 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -580,53 +586,105 @@ class LogManager(logDirs: Seq[File], * to avoid exposing data that