[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-19 Thread GitBox
dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526729269 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1404,60 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics:

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r525953666 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1476,33 +1650,36 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r525888208 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-11 Thread GitBox
dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521346721 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,