[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1100441588 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2455,7 +2454,7 @@ private void close(Duration timeout, boolean swallowException) {

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1100295718 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -447,6 +430,33 @@ private RequestFuture

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1100288626 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1044655133 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1044643791 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -590,6 +595,14 @@ public boolean handleResponse(FetchResponse response, short version)

[GitHub] [kafka] dajac commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r976472636 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -590,6 +595,14 @@ public boolean handleResponse(FetchResponse response, short version)