[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068220054 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068171485 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1068168361 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -164,5 +166,20 @@ CompletableFuture> fetch String groupId,

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1067001037 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -436,4 +440,74 @@ class GroupCoordinatorAdapterTest {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r106727 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel, /** * Handle an offset commit

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066999003 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,79 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066989454 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,79 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066988206 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066981875 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1065606143 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1057149271 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1054822770 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel, /** * Handle an offset commit

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1054778967 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel, * Handle an offset commit request

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1054592382 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -407,136 +416,200 @@ class KafkaApis(val requestChannel: RequestChannel, * Handle an offset commit request

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1054582822 ## core/src/main/java/kafka/server/builders/KafkaApisBuilder.java: ## @@ -178,6 +179,7 @@ public KafkaApis build() { metadataSupport,