[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081788435 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter( } override

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081583343 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571516 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3448,7 +3445,7 @@ class KafkaApisTest { val expectedJoinGroupResponse = new

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571061 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -511,4 +532,53 @@ class GroupCoordinatorAdapter( future } + + override def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1074022302 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel, if (topicPartition.topic ==

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073982833 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073958844 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -511,4 +532,53 @@ class GroupCoordinatorAdapter( future } + + override def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073895006 ## core/src/test/resources/log4j.properties: ## @@ -18,7 +18,7 @@ log4j.appender.stdout=org.apache.log4j.ConsoleAppender

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073607143 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073607143 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int, */ private def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073605900 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -357,8 +354,9 @@ class KafkaApis(val requestChannel: RequestChannel, new UpdateMetadataResponse(new

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073334166 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel, if (topicPartition.topic ==

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r107332 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -511,4 +532,57 @@ class GroupCoordinatorAdapter( future } + + override def

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1073331102 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -282,8 +283,12 @@ class BrokerServer( tokenManager.startup() // does nothing, we just need a token