[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1108852113 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -44,11 +44,40 @@ import org.apache.kafka.common.utils.Time import org.apache.kafka.common.{IsolationLevel,

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1108755781 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -285,6 +314,17 @@ class Partition(val topicPartition: TopicPartition, // If ReplicaAlterLogDir command is

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1108755031 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -44,11 +44,40 @@ import org.apache.kafka.common.utils.Time import org.apache.kafka.common.{IsolationLevel,

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1108753117 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -44,11 +44,40 @@ import org.apache.kafka.common.utils.Time import org.apache.kafka.common.{IsolationLevel,

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1108752686 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -318,6 +358,25 @@ class Partition(val topicPartition: TopicPartition, def inSyncReplicaIds: Set[Int] =

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1104123007 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -49,6 +49,35 @@ import org.apache.kafka.server.log.internals.{AppendOrigin, FetchDataInfo, Fetch import

[GitHub] [kafka] dajac commented on a diff in pull request #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac commented on code in PR #13196: URL: https://github.com/apache/kafka/pull/13196#discussion_r1098775244 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -334,6 +334,29 @@ class ReplicaManager(val config: KafkaConfig, topicPartitions.foreach(tp =>