[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-15 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136820680 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -130,10 +131,35 @@ private static Optional optionalEpoch(int rawEpochValue) {

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-14 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1135754940 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -130,10 +131,33 @@ private static Optional optionalEpoch(int rawEpochValue) {

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

2023-03-10 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132627550 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +320,19 @@ public String toString() { } } +// Downgrades

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

2023-03-08 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1129840701 ## core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala: ## @@ -44,7 +44,10 @@ object KafkaNetworkChannel { case fetchRequest: FetchRequestData => //

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

2023-03-08 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1129828078 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +320,31 @@ public String toString() { } } +public static

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

2023-03-02 Thread via GitHub
dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123094538 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest( RaftRequest.Inbound