[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1152957342 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -861,8 +872,9 @@ public void testEarlyControllerResults() throws Throwable { }

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1150489001 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -2324,12 +2324,18 @@ class KafkaController(val config: KafkaConfig, case Some(topicName) =

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431864 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1156,9 +1169,32 @@ private Errors validateAlterPartitionData( }

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431780 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -596,6 +596,11 @@ public void checkBrokerEpoch(int brokerId, long brokerEpoch) {

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431107 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1930,4 +1966,24 @@ public String toString() { return replicaId +