[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172945841 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172946358 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172621475 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172597532 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172519824 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172253675 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172252094 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172250882 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/VersionedMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172243757 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/AssignmentTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172236944 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-20 Thread via GitHub
dajac commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1172227215 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software