[GitHub] [kafka] dajac commented on a diff in pull request #14056: KAFKA-14501: Implement Heartbeat protocol in new GroupCoordinator

dajac commented on code in PR #14056: URL: https://github.com/apache/kafka/pull/14056#discussion_r1277524963 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -843,15 +886,19 @@ public JoinGroupResponseData setupGroupWith

[GitHub] [kafka] dajac commented on a diff in pull request #14056: KAFKA-14501: Implement Heartbeat protocol in new GroupCoordinator

dajac commented on code in PR #14056: URL: https://github.com/apache/kafka/pull/14056#discussion_r1276310475 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -347,9 +369,29 @@ public CompletableFuture heartbeat(

[GitHub] [kafka] dajac commented on a diff in pull request #14056: KAFKA-14501: Implement Heartbeat protocol in new GroupCoordinator

dajac commented on code in PR #14056: URL: https://github.com/apache/kafka/pull/14056#discussion_r1273976287 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -368,9 +369,29 @@ public CompletableFuture heartbeat(