[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1341653044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -849,6 +853,42 @@ public void validateOffsetFetch( }

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1340716345 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -262,6 +267,44 @@ public HeartbeatResponseData

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1334519906 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -90,4 +90,29 @@ void validateOffsetFetch( int memberEpoch, long

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1334471084 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -523,9 +526,63 @@ public CompletableFuture>

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1333162337 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -849,6 +853,46 @@ public void validateOffsetFetch( }

[GitHub] [kafka] dajac commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1332632377 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -523,9 +525,46 @@ public CompletableFuture> groupsByPartition

[GitHub] [kafka] dajac commented on a diff in pull request #14408: Kafka 14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1332073736 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -454,6 +454,25 @@ public static Record newGroupMetadataTombstoneRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14408: Kafka 14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1332072625 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -262,6 +267,45 @@ public HeartbeatResponseData

[GitHub] [kafka] dajac commented on a diff in pull request #14408: Kafka 14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1332069169 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -592,6 +607,45 @@ public void validateOffsetFetch(

[GitHub] [kafka] dajac commented on a diff in pull request #14408: Kafka 14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1332057781 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -523,9 +526,38 @@ public CompletableFuture> groupsByPartition

[GitHub] [kafka] dajac commented on a diff in pull request #14408: Kafka 14506: Implement DeleteGroups API and OffsetDelete API

dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1331125886 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -523,9 +526,38 @@ public CompletableFuture> groupsByPartition