[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-25 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1734049140 I've got two good builds for this PR: * https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14402/17/tests *

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-21 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1729476773 @jolshan I just found similar failures in another PR: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14418/1/tests. That seems to indicate that the

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-21 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1728941550 Last build looks good. I just triggered another one to confirm it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-20 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1728138099 > Thanks David -- things look reasonable, but I will wait to approve until we figure out the test issue. Thanks Justine. Interestingly, I cannot repro those failures locally... I

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-20 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1727949668 There are some weird failures in the last [run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14402/5/tests). I will investigate those... -- This is

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-20 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1727118482 @jolshan Thanks for your comments. I have addressed them and I have also fixed the build. See changes in BrokerServer and KafkaServer. -- This is an automated message from the Apache Git