[GitHub] [kafka] dengziming commented on a change in pull request #2140: KAFKA-4390: Replace MessageSet usage with client-side alternatives

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #2140: URL: https://github.com/apache/kafka/pull/2140#discussion_r563471404 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -44,83 +53,435 @@ public FileRecords(File file, this.c

[GitHub] [kafka] dengziming commented on a change in pull request #2140: KAFKA-4390: Replace MessageSet usage with client-side alternatives

2021-01-25 Thread GitBox
dengziming commented on a change in pull request #2140: URL: https://github.com/apache/kafka/pull/2140#discussion_r564172786 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -44,83 +53,435 @@ public FileRecords(File file, this.c

[GitHub] [kafka] dengziming commented on a change in pull request #2140: KAFKA-4390: Replace MessageSet usage with client-side alternatives

2021-01-24 Thread GitBox
dengziming commented on a change in pull request #2140: URL: https://github.com/apache/kafka/pull/2140#discussion_r563471404 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -44,83 +53,435 @@ public FileRecords(File file, this.c