[GitHub] [kafka] dengziming commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-11 Thread GitBox
dengziming commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870922245 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -102,6 +106,8 @@ class KafkaRaftServer( threadNamePrefix,

[GitHub] [kafka] dengziming commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

2022-05-06 Thread GitBox
dengziming commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r866465436 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -299,4 +299,30 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {