[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-19 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1171232959 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-18 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170758199 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-16 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1167773347 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java: ## @@ -260,12 +261,29 @@ public void onFailure(

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-16 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1167684205 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4579,7 +4374,7 @@ void maybeRetry(long currentTimeMs, Throwable throwable) {

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-06 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1159538238 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-04-06 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1159516278 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-03-24 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1147319995 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java: ## @@ -70,6 +71,22 @@ */ ApiResult handleResponse(Node broker,