[GitHub] [kafka] dengziming commented on pull request #12294: KAFKA-13990: KRaft controller should return right features in ApiVersionResponse

2022-08-23 Thread GitBox
dengziming commented on PR #12294: URL: https://github.com/apache/kafka/pull/12294#issuecomment-1225097010 This is an issue of big influence since it will prevent us from upgrading KRaft cluster, also ping @hachikuji @mumrah -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dengziming commented on pull request #12294: KAFKA-13990: KRaft controller should return right features in ApiVersionResponse

2022-07-20 Thread GitBox
dengziming commented on PR #12294: URL: https://github.com/apache/kafka/pull/12294#issuecomment-1190983840 cc @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] dengziming commented on pull request #12294: KAFKA-13990: KRaft controller should return right features in ApiVersionResponse

2022-06-14 Thread GitBox
dengziming commented on PR #12294: URL: https://github.com/apache/kafka/pull/12294#issuecomment-1155049348 Hello @cmccabe , in #12207 you moved the validation from `FeatureControlManager.replay` to `FeatureControlManager.updateFeature`, but it's still failing since controller doesn't return