[GitHub] [kafka] dengziming commented on pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-26 Thread GitBox
dengziming commented on pull request #9819: URL: https://github.com/apache/kafka/pull/9819#issuecomment-767972954 @hachikuji @jsancio Thank you for your great patience! @jsancio your concerns seems similar to https://github.com/apache/kafka/pull/9970#discussion_r564747239 , we can discu

[GitHub] [kafka] dengziming commented on pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-23 Thread GitBox
dengziming commented on pull request #9819: URL: https://github.com/apache/kafka/pull/9819#issuecomment-766289814 @hachikuji ,Thank you for your suggestions, I found `DefaultRecordsSend` similar to `UnalignedRecordsSend ` so I added a generic type to`DefaultRecordsSend`, and also added a p

[GitHub] [kafka] dengziming commented on pull request #9819: KAFKA-10694: Implement zero copy for FetchSnapshot

2021-01-18 Thread GitBox
dengziming commented on pull request #9819: URL: https://github.com/apache/kafka/pull/9819#issuecomment-762627649 @hachikuji @jsancio @ijuma ,Hello, This pr is ready for a second review, Thank you. This is an automated messa