[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-04 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1184786130 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,39 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def testRemove

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183658413 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,39 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def testRemove

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183654795 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -466,6 +472,17 @@ object LogCleaner { config.logCleanerEnable) } + + private val MaxBufferUtil

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183654517 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,39 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def testRemove

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182721302 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182715489 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -124,29 +124,37 @@ class LogCleaner(initialConfig: CleanerConfig, private def maxOverCleanerThreads(f: C

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182552980 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182536794 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in