[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

2023-03-01 Thread via GitHub
divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1450105039 > This is less concerning because the MirrorMaker class isn't part of public API; It's not technically part of public API but it has a `main()` method which is executed by the

[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

2023-02-28 Thread via GitHub
divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1448267997 Thank you for the detailed explanation @C0urante! > so this doesn't really buy us much right now. Oops, my bad! I did not notice that. > this only guarantees that

[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

2023-02-21 Thread via GitHub
divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1438985658 @C0urante please take a look when you get a chance. `unitTest` and `integrationTest` succeed for me locally. -- This is an automated message from the Apache Git Service. To respond