[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2022-06-11 Thread GitBox
dongjinleekr commented on PR #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-1152931211 @mimaison Here it is, with rebasing onto the latest trunk. :bow: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2022-06-05 Thread GitBox
dongjinleekr commented on PR #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-1146912052 Rebased onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2022-06-05 Thread GitBox
dongjinleekr commented on PR #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-1146907489 Retest this please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2022-05-27 Thread GitBox
dongjinleekr commented on PR #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-1139642061 @splett2 @mimaison Sorry for being late. Here is the fix. Not only rebasing onto the latest trunk, I carefully inspected the implementation of `BrokerTopicStats` and did the fo

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-21 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-974783260 @dajac Here is the update; As you can see here, only `Message conversion rate` and `Rejected byte rate` have detailed descriptions now. -- This is an automated message fr

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-21 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-974783260 @dajac Here is the update; As you can see here, only `Message conversion rate` and `Rejected byte rate` have detailed descriptions now. -- This is an automated message fr

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-09 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-964723611 As soon as this PR is merged, I will open a corresponding PR in `kafka-site`. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-09 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-964723425 @splett2 Here is the fix. Reviewing the documentation, I found that 1. the other 'BrokerTopicMetrics' metrics are omitting `,topic=([-.\w]+)` at the end 2. also omitting th

[GitHub] [kafka] dongjinleekr commented on pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2021-11-08 Thread GitBox
dongjinleekr commented on pull request #11473: URL: https://github.com/apache/kafka/pull/11473#issuecomment-963630902 @splett2 Could you have a look while I am updating #11474? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub