[GitHub] [kafka] fvaleri commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-24 Thread via GitHub
fvaleri commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1271824235 ## tools/src/main/java/org/apache/kafka/tools/StorageTool.java: ## @@ -0,0 +1,479 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [kafka] fvaleri commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1270828901 ## checkstyle/import-control.xml: ## @@ -302,6 +302,11 @@ + + + + + Review Comment: This entry is duplicated, and we don't nee

[GitHub] [kafka] fvaleri commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-07 Thread via GitHub
fvaleri commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1255759422 ## tools/src/main/java/org/apache/kafka/tools/StorageTool.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont