[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-09 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501942512 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -653,36 +697,44 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r502078584 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -782,7 +782,7 @@ class LogTest { } // Retain snapshots for the last

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501979388 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -1226,6 +1225,104 @@ class LogTest { assertEquals(retainedLastSeqOpt,

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501970716 ## File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala ## @@ -834,6 +834,40 @@ class ProducerStateManagerTest {

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501968249 ## File path: core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala ## @@ -834,6 +834,40 @@ class ProducerStateManagerTest {

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501957800 ## File path: core/src/test/scala/unit/kafka/log/LogTest.scala ## @@ -1226,6 +1225,104 @@ class LogTest { assertEquals(retainedLastSeqOpt,

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501944185 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -496,6 +491,53 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-08 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r501942512 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -653,36 +697,44 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] gardnervickers commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-17 Thread GitBox
gardnervickers commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r441719784 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -751,6 +751,25 @@ class ProducerStateManager(val topicPartition: