gharris1727 commented on code in PR #13575:
URL: https://github.com/apache/kafka/pull/13575#discussion_r1173979163
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java:
##########
@@ -38,16 +38,13 @@
import java.util.Collection;
import java.util.Map;
import java.util.concurrent.ExecutionException;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
/** Customised ForwardingAdmin for testing only.
* The class create/alter topics, partitions and ACLs in Kafka then store
metadata in {@link FakeLocalMetadataStore}.
* */
public class FakeForwardingAdminWithLocalMetadata extends ForwardingAdmin {
private static final Logger log =
LoggerFactory.getLogger(FakeForwardingAdminWithLocalMetadata.class);
- private final long timeout = 1000L;
Review Comment:
I didn't just raise the timeout because the MirrorSourceTask that makes
these calls does not have a timeout that I could predictably meet. The task
appears to either use `get()` or `whenComplete` on the futures returned by
these calls.
I think your critique is correct though, and I've rewritten this to use
whenComplete() to get the results of the futures, instead of get().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
