gharris1727 opened a new pull request, #14230:
URL: https://github.com/apache/kafka/pull/14230

   This test uses a standalone worker to verify the behavior of the 
plugin.discovery configuration values with non-migrated and migrated artifacts. 
   
   For a source of non-migrated artifacts, I'm getting the latest 3.5.x File 
connectors, which will not receive manifests. When I originally planned this 
testing, I thought I would add non-migrated connectors to the `test-plugins` 
artifact, but that would make it difficult for downstream projects to import 
that jar and run in hybrid_fail.
   
   The templates are changed to provide the default `service_load` to hopefully 
speed up execution of the other system tests. I will running the full suite of 
connect system tests to verify that this is a reasonable change.
   
   This test verifies that:
   1. Backwards-compatible modes (only_scan and hybrid_warn) start up 
successfully and the file connectors are visible.
   2. The hybrid_fail mode crashes the worker if and only if non-migrated 
plugins are present.
   3. The service_load mode starts up successfully, and file connectors are 
visible if and only if they are migrated.
   4. The dry-run does not migrate connectors.
   5. The sync-manifest writes well-formed jars that are readable during worker 
startup.
   
   The test runtime is <5m on my machine. I considered adding no-command and 
`list` cases, but thought they duplicated the `--dry-run` case and increased 
the runtime for very little added value. I did change the distributed template 
and the ConnectDistributedService so that they could run this same test, but 
didn't set up a matrix for the deployment type for the same reason.
   
   I did not include migrations for other plugin types (converters, transforms, 
etc) or packaging styles (class hierarchy, single-jar) because this is already 
covered in unit tests. I did not include assertions for the WARN log statements 
printed during hybrid modes for the same reason.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to