[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-21 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r927019010 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -262,51 +294,30 @@ Collection tasks(final Collection taskIds) { // TO

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925945110 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java: ## @@ -216,8 +216,9 @@ long partitionTimestamp(final TopicPartition parti

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925892759 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ## @@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() { l

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925882848 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -34,29 +33,40 @@ import java.util.TreeMap; import java.util.stream.Collect

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925881686 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java: ## @@ -55,25 +57,28 @@ public abstract class AbstractTask implements Task {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925880702 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1307,9 +1307,9 @@ public Set characteristics() { } @SafeVarargs -public st

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-08 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r917191699 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -34,29 +33,40 @@ import java.util.TreeMap; import java.util.stream.Collect