[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148071896 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -0,0 +1,791 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148026726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -172,606 +69,41 @@ public boolean hasAvailableFetches() { * @return

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-23 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1146964838 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -154,7 +155,8 @@ public class ConsumerConfig extends AbstractConfig {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-23 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1146949108 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -154,7 +155,8 @@ public class ConsumerConfig extends AbstractConfig {