guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-959799444
@shirenchuang Thanks. Let's just focus on the ZK path for this PR then.
Please ping @junrao and myself after you've added the unit test: note it should
verify that upon
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-959799444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-959799444
@shirenchuang Thanks. Let's just focus on the ZK path for this PR then.
Please ping @junrao and myself after you've added the unit test: note it should
verify that upon
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-956859211
+1 to @junrao 's comment, could you fix the sorting in
`ReplicationControlManager` too, and also add a unit test (similar to the one
you used to illustrate this issue) to
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-956859211
+1 to @junrao 's comment, could you fix the sorting in
`ReplicationControlManager` too, and also add a unit test (similar to the one
you used to illustrate this issue) to
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-956859211
+1 to @junrao 's comment, could you fix the sorting in
`ReplicationControlManager` too, and also add a unit test (similar to the one
you used to illustrate this issue) to
