guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1126350779
AH yes, that's clear.
My concern was that it's assuming the defined properties should be all
retrieved in the constructor (since the `logUnused` is called at the end of
it).
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1117635812
Thanks @C0urante for your thoughts. I'd like to clarify one thing that,
today users can pass in both defined and unknown config values, where the
latter may be used in some plugin
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1108911987
@C0urante Yes I agree this is a fair question to debate on, and I personally
think that it could be very subjective --- as you can see in
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1104256988
I agree with @RivenSun2 's rationale here. More specifically I think 1) we
are not really trying to just ignore all configs that are not used; instead we
just want to 2) not print
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099741042
LGTM. Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
